This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions

From: Eli Zaretskii <eliz at gnu dot org>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, Richard dot Bunt at arm dot com
Date: Sat, 30 Mar 2019 10:15:01 +0300
Subject: Re: [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions
References: <cover.1552913183.git.andrew.burgess@embecosm.com> <cover.1552913183.git.andrew.burgess@embecosm.com> <854230b716fa6838bd2d8e73f1fd2d342a7a75ed.1552913183.git.andrew.burgess@embecosm.com> <83va0gumjp.fsf@gnu.org> <20190329224116.GI10887@embecosm.com>

> Date: Fri, 29 Mar 2019 22:41:16 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: gdb-patches@sourceware.org, Richard.Bunt@arm.com
> 
> What I've done is group the @item entries for $_creal and $_cimag
> together.  My thinking is that if a user looks up either of these then
> the documentation should be complete.  If I left the @item entries
> separate, and removed the sentence as you suggested then I think I'd
> have to add a cross reference.
> 
> Hopefully this will be OK.

I have only one comment:

> +@item $_cimag(@var{value})
> +@item $_creal(@var{value})

The second @item should be @itemx.

Thanks.

References:
- [PATCH 0/8] Series of Fortran type printing patches
  - From: Andrew Burgess
- [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions
  - From: Andrew Burgess
- Re: [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions
  - From: Eli Zaretskii
- Re: [PATCH 1/8] gdb: Add $_cimag and $_creal internal functions
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]