This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 16/22] Rewrite TRY/CATCH
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 3 Apr 2019 18:03:49 +0100
- Subject: Re: [PATCH v2 16/22] Rewrite TRY/CATCH
- References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-17-tom@tromey.com>
On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This rewrites gdb's TRY/CATCH to plain C++ try/catch. The patch was
> largely written by script, though one change (to a comment in
> common-exceptions.h) was reverted by hand.
I reviewed this one and the next as a squashed view (any reason you
didn't squash them?), and it looks OK to me, though personally
I'd much prefer to see the explicit "struct" in:
- CATCH (e, RETURN_MASK_ERROR)
+ catch (const struct gdb_exception_error &e)
go away, and end up with just:
catch (const gdb_exception_error &e)
Thanks,
Pedro Alves