This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/13] Remove parser-related globals
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 3 Apr 2019 19:14:50 +0100
- Subject: Re: [PATCH 00/13] Remove parser-related globals
- References: <20190403013805.11978-1-tom@tromey.com>
On 04/03/2019 02:37 AM, Tom Tromey wrote:
> This series removes the remaining globals from the generic parser code
> (individual parsers may still have globals -- in fact, aside from
> Rust, all do). One upside of the series is that it makes it more
> clear which objects are used to communicate between the parser API and
> the individual parsers.
>
> Regression tested by the buildbot.
>
Wow. Very nice. I skimmed it and it LGTM.
In the type_stack patch:
> +/* The type stack is an instance of this structure. */
> +
> +struct type_stack
> +{
> +public:
> +
> + type_stack ()
> + {
> + }
You can write:
type_stack () = default;
As is makes it read like you intended to initialize
something but forgot.
Thanks,
Pedro Alves