This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Sort #includes in gdb
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Wed, 03 Apr 2019 23:40:51 -0400
- Subject: Re: [RFC] Sort #includes in gdb
- References: <87fttfmnpq.fsf@tromey.com> <e132876c-15b3-7c47-f765-5c2db103b38e@redhat.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <f172a298-809a-d928-9f5f-f65300826be2@redhat.com> <875zs1csim.fsf@tromey.com> <d077cc5fe3eb77bdb85ffa2ec2ca306c@polymtl.ca> <87bm1s1a98.fsf@tromey.com> <bbc50b79-fce1-6d62-d43a-b8a730eb8e4b@redhat.com> <87h8ben803.fsf@redhat.com> <878swqfpw7.fsf@tromey.com>
On Wednesday, April 03 2019, Tom Tromey wrote:
> Sergio> I'm still investigating, but I think the "--branch" option doesn't
> Sergio> specify a branch to be tested; rather, it specified a branch where the
> Sergio> test should be performed. I.e., you still have to provide a patch. We
> Sergio> currently just support testing against origin/master (that's why, on
> Sergio> .buildbot/options, we specify the "try_branch" variable as being
> Sergio> "origin/master").
>
> Yeah, what I did is push my branch, then commit a trivial change and use
> "buildbot try --branch origin/users/tromey/...".
The problem with that is that BuildBot needs to know which branch to use
when comparing builds. If you specify a branch that's not
origin/master, then there are no previous results to compare against.
Maybe it could work if you created a new branch, waited 1 hour or so
(because our BuildBot doesn't fetch directly from sourceware.org;
instead, it uses a mirror, so you have to wait until your branch
propagates), commited a trivial change, built it, then put the huge
patch on top of it, then put another trivial patch on top, and built it
again. Not very cool.
> I think it's fine to just test & land this patch in pieces. Normally
> patches aren't so big.
Again, sorry about the limitations of BuildBot. I remember spending a
considerable amount of time trying to increase the patch size that's
accepted, but unfortunately the change would have to be propagated to
every buildslave, which is not feasible.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/