Re: [PATCH, testsuite] Add cc-with-dwz.exp add cc-with-dwz-m.exp

[Pedro Alves <palves at redhat dot com>]

On 4/10/19 10:40 AM, Tom de Vries wrote:
> Hi,
> 
> While we can use CC_WITH_TWEAKS_FLAGS like this:
> ...
> $ cd $objdir/gdb
> $ make check \
>     RUNTESTFLAGS='--target_board=cc-with-tweaks' \
>     CC_WITH_TWEAKS_FLAGS='-z'
> ...
> this doesn't work:
> ...
> $ cd $objdir
> $ make check-gdb \
>     RUNTESTFLAGS='--target_board=cc-with-tweaks' \
>     CC_WITH_TWEAKS_FLAGS='-z'
> ...

Took me a bit to understand the difference here.  I think
spelling it out in English helps.  So, in the first case,
you're cd-ing to the gdb subdir and using "make check".
While in the second case, you're cd-ing to the top build dir,
and using "make check-gdb".

> 
> Add cc-with-dwz.exp add cc-with-dwz-m.exp, that can be used like this:
> ...
> $ cd $objdir
> $ make check-gdb \
>     RUNTESTFLAGS='--target_board=cc-with-dwz'
> ...

Sorry for being dense, but I was completely confused by this
description for a bit.  I didn't really understand what the
conclusion (new board) files had to do with the premise
("while this works, this does not").  And why does check-gdb
vs check make a difference?  I suspect that it's because CC_WITH_TWEAKS_FLAGS
is not passed down from the top level?  If so, or even if it's
something else, could you clarify both the proposed git commit
log, and the "does not work" comment added to the existing 
.exp file (add a "because CC_WITH_TWEAKS_FLAGS is not passed
down from the top level Makefile" or something like that), please?

Would passing down CC_WITH_TWEAKS_FLAGS from the top level be
a bad idea?

I do wonder why not just do the "cd $objdir/gdb" version instead.
Hope we don't grow into combinatorial explosion. :-D

Thanks,
Pedro Alves

> 
> Tested on x86_64-linux.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] Add cc-with-dwz.exp add cc-with-dwz-m.exp
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-04-10  Tom de Vries  <tdevries@suse.de>
> 
> 	* boards/cc-with-dwz-m.exp: New file.
> 	* boards/cc-with-dwz.exp: New file.
> 	* boards/cc-with-tweaks.exp: Note that check-gdb doesn't work.
> 
> ---
>  gdb/testsuite/boards/cc-with-dwz-m.exp  | 28 ++++++++++++++++++++++++++++
>  gdb/testsuite/boards/cc-with-dwz.exp    | 28 ++++++++++++++++++++++++++++
>  gdb/testsuite/boards/cc-with-tweaks.exp |  3 +++
>  3 files changed, 59 insertions(+)
> 
> diff --git a/gdb/testsuite/boards/cc-with-dwz-m.exp b/gdb/testsuite/boards/cc-with-dwz-m.exp
> new file mode 100644
> index 0000000000..f5348508a1
> --- /dev/null
> +++ b/gdb/testsuite/boards/cc-with-dwz-m.exp
> @@ -0,0 +1,28 @@
> +# Copyright 2019 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# This file is a dejagnu "board file" and is used to run the testsuite
> +# with contrib/cc-with-tweaks.sh -m.
> +#
> +# NOTE: We assume dwz is in $PATH.
> +#
> +# Example usage:
> +# bash$ cd $objdir
> +# bash$ make check-gdb \
> +#   RUNTESTFLAGS='--target_board=cc-with-dwz-m' \
> +#
> +
> +set CC_WITH_TWEAKS_FLAGS "-m"
> +load_board_description "cc-with-tweaks"
> diff --git a/gdb/testsuite/boards/cc-with-dwz.exp b/gdb/testsuite/boards/cc-with-dwz.exp
> new file mode 100644
> index 0000000000..dcf44f48c3
> --- /dev/null
> +++ b/gdb/testsuite/boards/cc-with-dwz.exp
> @@ -0,0 +1,28 @@
> +# Copyright 2019 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# This file is a dejagnu "board file" and is used to run the testsuite
> +# with contrib/cc-with-tweaks.sh -z.
> +#
> +# NOTE: We assume dwz is in $PATH.
> +#
> +# Example usage:
> +# bash$ cd $objdir
> +# bash$ make check-gdb \
> +#   RUNTESTFLAGS='--target_board=cc-with-dwz' \
> +#
> +
> +set CC_WITH_TWEAKS_FLAGS "-z"
> +load_board_description "cc-with-tweaks"
> diff --git a/gdb/testsuite/boards/cc-with-tweaks.exp b/gdb/testsuite/boards/cc-with-tweaks.exp
> index 59a53a87f9..2fac669453 100644
> --- a/gdb/testsuite/boards/cc-with-tweaks.exp
> +++ b/gdb/testsuite/boards/cc-with-tweaks.exp
> @@ -19,10 +19,13 @@
>  # NOTE: If using dwz, We assume it is in $PATH.
>  #
>  # Example usage:
> +# bash$ cd $objdir/gdb
>  # bash$ make check \
>  #   RUNTESTFLAGS='--target_board=cc-with-tweaks' \
>  #   CC_WITH_TWEAKS_FLAGS='-z'
>  #
> +# Note: this does not work from $objdir with make check-gdb.
> +#
>  # The default value of CC_WITH_TWEAKS_FLAGS is "".
>  
>  if ![info exists CC_WITH_TWEAKS_FLAGS] {
>