Re: [PATCH 2/3] Fix a couple of comments

[Tom Tromey <tom at tromey dot com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2019-04-09 2:09 p.m., Tom Tromey wrote:
>> While working on objfiles I noticed a typo in one comment, and another
>> comment that, as far as I can tell, has been obsolete for a very long
>> time.

Simon> I don't really understand the comment.  Is it obsolete because what the
Simon> comment suggests has been implemented, or it's just not relevant anymore?

The comment was this one in reread_symbols:

-  /* With the addition of shared libraries, this should be modified,
-     the load time should be saved in the partial symbol tables, since
-     different tables may come from different source files.  FIXME.
-     This routine should then walk down each partial symbol table
-     and see if the symbol table that it originates from has been changed.  */

I am not totally sure how to interpret this either.  On the one hand, it
sounds done (objfiles for shared libraries record the mtime, this
function examines those); on the other it sounds confused (partial
symbol tables aren't relevant here).  Maybe there was some ancient time
when shared libraries didn't have separate objfiles?  I do not know.

Tom