This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Testsuite: Add gdbserver sysroot test
On 4/10/19 1:10 PM, Alan Hayward wrote:
>> Fix for that posted:
>> https://sourceware.org/ml/gdb-patches/2019-04/msg00141.html
>
> Excellent. I would give it a review, but don’t know anything in that area.
Review is often an excellent way to learn about new areas. :-)
>>
>> Hit M-q in your emacs here.
>
> Done (assuming you just meant to wrap before column 80).
Right.
>> Use clean_restart, and add period:
>>
>> # Restart GDB.
>> clean_restart
>
> This was intentional to avoid the “file” command at the end of clean_restart.
The "file" command at the end is only run if you pass an argument to clean_restart.
if { [llength $args] >= 1 } {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
set executable [lindex $args 0]
set binfile [standard_output_file ${executable}]
gdb_load ${binfile}
}
Please do add the all-important period. :-)
> +
> + # Set the sysroot.
> + gdb_test_no_output "set sysroot $sysroot_command"
> +
> + # Connect to gdbsever, making sure GDB reads in the binary correctly.
type: "gdbsever"
> + set test "connect to remote and read binary"
>
> #
> # gdb_target_cmd
> -# Send gdb the "target" command
> +# Send gdb the "target" command. Returns 0 on success, 1 on failure.
Double space after period.
> +# If specified, then additional_text must match the text which must comes after
Uppercase ADDITIONAL_TEXT.
s/which must comes/that comes/ ?
> +# the connection message in order for procedure to succeed.
s/for procedure/for the procedure/.
OK with the issues mentioned above fixed.
Thanks,
Pedro Alves