This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] gdb/nds32: Use type_align instead of nds32_type_align
On Sat, 13 Apr 2019 00:25:34 +0100
Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> The general type_align method should be a suitable alternative to
> nds32_type_align, so switch to use that.
>
> The only change this will introduce is related to static fields in a
> struct or union, the existing code doesn't take account of static
> fields when computing the alignment for structs of unions, though this
> is probably a bug - which would probably be exposed by the test case
> gdb.cp/many-args.exp, though I don't have any way to test this target
> right now.
>
> gdb/ChangeLog:
>
> * nds32-tdep.c (nds32_type_align): Delete.
> (nds32_push_dummy_call): Use type_align instead.
I think that nds32_type_align needs to be registered in
nds32_gdbarch_init().
Otherwise, LGTM.
Kevin