This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 2/2] MI: Add new command -complete
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jan Vrany <jan dot vrany at fit dot cvut dot cz>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 18 Apr 2019 15:50:50 +0300
- Subject: Re: [PATCH v4 2/2] MI: Add new command -complete
- References: <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <20190418115847.19854-3-jan.vrany@fit.cvut.cz>
> From: Jan Vrany <jan.vrany@fit.cvut.cz>
> Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
> Date: Thu, 18 Apr 2019 12:58:47 +0100
>
> +The result consists of two one or two fields:
^^^^^^^^^^^^^^
A typo.
> +@smallexample
> +(gdb)
> +-complete br
> +^done,completion="break",matches=["break","break-range"],max_completions_reached="0"
> +(gdb)
> +-complete "b ma"
> +^done,completion="b ma",matches=["b madvise","b main"],max_completions_reached="0"
> +(gdb)
> +-complete "b push_b"
> +^done,completion="b push_back(",
> + matches=["b A::push_back(void*)",
> + "b std::string::push_back(char)",
> + "b std::vector<int, std::allocator<int> >::push_back(int&&)"],
> + max_completions_reached="0"
The "done" lines are too long, please break them into lines shorter
than 70 characters.
Otherwise, the documentation parts are OK.
Thanks.