This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH][gdb/testsuite] Fix break-probes.exp with native-gdbserver
- From: Tom de Vries <tdevries at suse dot de>
- To: gdb-patches at sourceware dot org
- Date: Thu, 18 Apr 2019 18:50:13 +0200
- Subject: [PATCH][gdb/testsuite] Fix break-probes.exp with native-gdbserver
Hi,
When running break-probes.exp with native-gdbserver, we run into:
...
FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
FAIL: gdb.base/break-probes.exp: call (int) foo(23)
...
due to the fact that we're trying to match:
...
Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
/break-probes/break-probes-solib.so
...
using pattern:
...
Inferior loaded $sysroot$binfile_lib
...
which expands into:
...
Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
/break-probes/break-probes-solib.so
...
Fix this by removing trailing slashes from the sysroot variable.
Tested on x86_64-linux with native and native-gdbserver (with sysroot set to
"/", "/." and "/./").
OK for trunk?
Thanks,
- Tom
[gdb/testsuite] Fix break-probes.exp with native-gdbserver
gdb/testsuite/ChangeLog:
2019-04-18 Tom de Vries <tdevries@suse.de>
PR gdb/24433
* gdb.base/break-probes.exp: Remove trailing slash from sysroot
variable.
---
gdb/testsuite/gdb.base/break-probes.exp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdb/testsuite/gdb.base/break-probes.exp b/gdb/testsuite/gdb.base/break-probes.exp
index ca9a7841f1..3c826e1aad 100644
--- a/gdb/testsuite/gdb.base/break-probes.exp
+++ b/gdb/testsuite/gdb.base/break-probes.exp
@@ -70,6 +70,9 @@ if { $using_probes } {
}
}
+ # Remove trailing slash.
+ regsub {/$} "$sysroot" "" sysroot
+
# GDB strips "target:" from the start of filenames
# when operating on the local filesystem
regsub "^target:" "$sysroot" "(target:)?" sysroot