This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation
- From: Tom Tromey <tom at tromey dot com>
- To: Tom Tromey <tromey at adacore dot com>
- Cc: "Leszek Swirski via gdb-patches" <gdb-patches at sourceware dot org>, Leszek Swirski <leszeks at google dot com>, palves at redhat dot com
- Date: Wed, 24 Apr 2019 12:03:46 -0600
- Subject: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation
- References: <20190214151602.147300-1-leszeks@google.com> <20190214151810.149322-1-leszeks@google.com> <87v9zducov.fsf@tromey.com> <87o955u7nl.fsf@tromey.com>
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> The appended fixes the test case that's included, but I'm not really
Tom> sure it's correct, since I am not sure that the test for
Tom> "bit-field-ness" is correct here.
Tom> Let me know what you think.
I'm checking this in now.
It seems to me that since this fixes the regression and also does not
regress the other new tests that it must be at least an improvement.
Tom