This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/5] More exception-handling improvements
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
- Date: Thu, 25 Apr 2019 19:08:23 +0100
- Subject: Re: [PATCH 0/5] More exception-handling improvements
- References: <20190425165256.31226-1-tromey@adacore.com>
On 4/25/19 5:52 PM, Tom Tromey wrote:
> Philippe noticed a memory leak with the new exception-handling code,
> and when I debugged it, I realized that the current code is relying on
> undefined behavior: namely, calling longjmp in a context where a
> destructor would normally run.
>
> This series fixes these problems, and provides some other improvements
> as well.
>
> Let me know what you think. Tested on x86-64 Fedora 29.
I think patches #1-#4 look fine.
I'd remove the explicit "struct"s throughout while at it,
but no biggie.
Not so clear on patch #5 -- see direct reply to that one.
Thanks,
Pedro Alves