This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/5] Fix memory leak in exception code

From: Tom Tromey <tromey at adacore dot com>
To: Tom Tromey <tromey at adacore dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Thu, 25 Apr 2019 12:30:54 -0600
Subject: Re: [PATCH 5/5] Fix memory leak in exception code
References: <20190425165256.31226-1-tromey@adacore.com> <20190425165256.31226-6-tromey@adacore.com> <30e99361-c252-53e2-ec7c-5a6bc7301a3f@redhat.com> <87ef5qaqyn.fsf@tromey.com>

Pedro> Why fix it like this, instead of fixing it like in the guile patch?
Pedro> I'd think you could even use a common POD type for both guile and here?

Tom> No particularly good reason.  I'll change it.

Actually, there was a reason.  Converting an exception to a POD means
copying the string contents.

Perhaps that isn't a big concern.  I guess only exceptions escaping to
the top level will do this.

Tom

Follow-Ups:
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Pedro Alves

References:
- [PATCH 0/5] More exception-handling improvements
  - From: Tom Tromey
- [PATCH 5/5] Fix memory leak in exception code
  - From: Tom Tromey
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Pedro Alves
- Re: [PATCH 5/5] Fix memory leak in exception code
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]