Re: [RFA] Have 'thread|frame apply' style their output.

[Philippe Waroquiers <philippe dot waroquiers at skynet dot be>]

On Sat, 2019-04-27 at 15:19 -0400, Simon Marchi wrote:
> On 2019-04-27 8:42 a.m., Philippe Waroquiers wrote:
> > Thanks for the review.  Pushed after fixing (for the "const?" comment,
> > I have added an explanation to clarify).
> > 
> > Philippe
> 
> Hi Philippe,
> 
> There is one more spot to update, which you'll find if you build with --with-guile:
> 
>   CXX    guile/guile.o
> /home/simark/src/binutils-gdb/gdb/guile/guile.c: In lambda function:
> /home/simark/src/binutils-gdb/gdb/guile/guile.c:310:62: error: too few arguments to function ‘std::__cxx11::string execute_command_to_string(const char*, int, bool)’
>   to_string_res = execute_command_to_string (command, from_tty);
>                                                               ^
> In file included from /home/simark/src/binutils-gdb/gdb/guile/guile.c:29:
> /home/simark/src/binutils-gdb/gdb/gdbcmd.h:140:20: note: declared here
>  extern std::string execute_command_to_string (const char *p, int from_tty,
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> I presume you'll want to pass false in this case, since it's specifically meant to
> send the output to a string, where we don't want styling?
Hello Simon,
I have just pushed a follow-up to fix the above.
At the same time, I saw that I forgot to copy/paste the ChangeLog
from the commit message to the ChangeLog file.
I fixed this also.

Sorry for the breakage, I have now added --with-guile as default.

Philippe

NB: this ChangeLog is a nightmare to produce (and maintain
for each version of a patch).  And then still a final copy-paste
from commit log to the real file to not forget.
(to avoid merge conflicts).

The only good point of ChangeLog is that this is reminding me of
the 80s, when I was young, and there was no good source control system,
and we were all proudly indicating in each source file what we changed
at what date :).

This ChangeLog is just slowing down the free software development
by moving away resources to useless painful administrative activities.
This must have been invented by an evil person that hates free software :).

I think I will now type it directly (but at the end of
the file), and move it at the beginning of the file just before
pushing.  At least, it reduces the nr of operations
(and I have a script I am running to automatically do some checks
before pushing, that I will make detect I forgot to move it).