This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style'

From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 03 Jun 2019 22:24:40 +0200
Subject: Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style'
References: <20190601212331.12085-1-philippe.waroquiers@skynet.be> <20190601212331.12085-2-philippe.waroquiers@skynet.be> <87tvd6msam.fsf@tromey.com>

On Mon, 2019-06-03 at 12:34 -0600, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
> 
> Philippe> +fputs_highlighted (const char *str, compiled_regex &highlight,
> 
> I think this can be "const compiled_regex &".  This is ok with this
> change (if it's not possible, it is ok without the change).

Pushed the series after doing the above change.

Thanks for the reviews

Philippe

References:
- [RFAv2 0/4] Improve "show style", have "help" and "apropos" styling their output.
  - From: Philippe Waroquiers
- [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style'
  - From: Philippe Waroquiers
- Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style'
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]