This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction
* Pedro Alves <palves@redhat.com> [2019-06-05 10:12:12 +0100]:
> On 6/4/19 12:50 PM, Andrew Burgess wrote:
> > + prologue scanner will try to decode it. These long
> > + instructions are ISA extensions, I use .byte rather than an
> > + actual instruction mnemonic so that the test can be compiled
>
> Tiny nit, but please avoid "I" in comments. Either just don't use a
> pronoun, e.g.:
>
> Since these long instructions are ISA extensions, use .byte
>
> or use "we" instead.
I pushed the patch below.
Thanks,
Andrew
--
commit 0088ba596bba2e0b94139f1c2c4f5875848edbd6
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date: Wed Jun 5 10:33:54 2019 +0100
gdb/testsuite: Improve comments in recently added test
Remove the use of 'I' within some comments in a recently added test.
gdb/testsuite/ChangeLog:
* gdb.arch/riscv-unwind-long-insn-6.s: Remove use of 'I' in
comment.
* gdb.arch/riscv-unwind-long-insn-8.s: Likewise.
diff --git a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s
index b21b1e10f32..9bbc0ca429b 100644
--- a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s
+++ b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s
@@ -29,7 +29,7 @@ bar:
func:
/* A fake 6 byte instruction. This is never executed, but the
prologue scanner will try to decode it. These long
- instructions are ISA extensions, I use .byte rather than an
+ instructions are ISA extensions, use .byte rather than an
actual instruction mnemonic so that the test can be compiled
with a toolchain that doesn't include any long instruction
extensions. */
diff --git a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s
index 3fad07b59dd..0bf86940a7b 100644
--- a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s
+++ b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s
@@ -29,7 +29,7 @@ bar:
func:
/* A fake 8 byte instruction. This is never executed, but the
prologue scanner will try to decode it. These long
- instructions are ISA extensions, I use .byte rather than an
+ instructions are ISA extensions, use .byte rather than an
actual instruction mnemonic so that the test can be compiled
with a toolchain that doesn't include any long instruction
extensions. */