This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove alloca(0) calls


On Tue, 11 Jun 2019 07:01:31 -0600
Tom Tromey <tromey@adacore.com> wrote:

> PR gdb/24653 points out that a gcc snapshot will complain about the
> calls to alloca(0) in gdb.
> 
> These calls are only needed when using the C alloca.  I'm inclined to
> think that no current platform needs this, so this patch removes the
> calls.
> 
> Let me know what you think.

I think that your patch should go in.

I too think that all modern platforms will have proper
(compiler-assisted) alloca support and won't need to resort to use of
the heap for implementation of alloca().

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]