This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix crash in cp_print_value_fields
- From: Tom Tromey <tom at tromey dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Tue, 18 Jun 2019 09:35:51 -0600
- Subject: Re: [PATCH] Fix crash in cp_print_value_fields
- References: <20190517201814.27951-1-tromey@adacore.com> <d7a187c4-df58-88b7-5763-003447aae181@suse.de>
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>> + cp_print_static_field (TYPE_FIELD_TYPE (type, i),
>> + v, stream, recurse + 1,
>> + options);
>> + }
Tom> Here options is used ...
>> catch (const gdb_exception_error &ex)
>> {
>> fprintf_filtered (stream,
>> _("<error reading variable: %s>"),
>> ex.what ());
>> }
>> -
>> - cp_print_static_field (TYPE_FIELD_TYPE (type, i),
>> - v, stream, recurse + 1, opts);
Tom> while here opts used to be used.
Tom> Is this change intentional? It's not mentioned anywhere.
Thanks for catching that. It was not intentional. I'll send a fix shortly.
Tom