This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb] Fix abstract_to_concrete type
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 18 Jun 2019 09:16:07 -0700
- Subject: Re: [PATCH][gdb] Fix abstract_to_concrete type
- References: <20190618093627.GA2117@delia>
On Tue, 18 Jun 2019 11:36:29 +0200
Tom de Vries <tdevries@suse.de> wrote:
> The test-case varval.exp fails here:
> ...
> FAIL: gdb.dwarf2/varval.exp: print varval2
> ...
> with boards readnow/cc-with-gdb-index/cc-with-debug-names, as well as if gdb
> is build with -fsanitize=address -lasan.
>
> The problem is that the abstract_to_concrete map in which we track the
> association of abstract to concrete DIEs (for DW_OP_GNU_variable_value
> support) has type std::unordered_map<die_info_ptr, std::vector<die_info_ptr>>,
> and the die_info_ptrs that we register in the map may be invalid by the time
> that we start to lookup DIEs in the map.
>
> Fix this by using the sect_offset instead to identify the DIEs in the map.
>
> Build and tested on x86_64-linux.
>
> OK for trunk?
Okay.
Thanks for fixing this!
Kevin