This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 01/66] Use new and delete for TUI windows
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sun, 23 Jun 2019 16:42:24 -0600
- Subject: [PATCH 01/66] Use new and delete for TUI windows
- References: <20190623224329.16060-1-tom@tromey.com>
This changes tui_win_info to use new and delete, rather than XNEW and
xfree.
gdb/ChangeLog
2019-06-23 Tom Tromey <tom@tromey.com>
* tui/tui-data.h (struct tui_win_info): Add constructor.
* tui/tui-data.c (tui_alloc_win_info): Use new.
(tui_free_window): Use delete.
---
gdb/ChangeLog | 6 ++++++
gdb/tui/tui-data.c | 5 ++---
gdb/tui/tui-data.h | 7 +++++++
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c
index b67cb48c2e6..117bda3c200 100644
--- a/gdb/tui/tui-data.c
+++ b/gdb/tui/tui-data.c
@@ -531,9 +531,8 @@ init_win_info (struct tui_win_info *win_info)
struct tui_win_info *
tui_alloc_win_info (enum tui_win_type type)
{
- struct tui_win_info *win_info = XNEW (struct tui_win_info);
+ struct tui_win_info *win_info = new struct tui_win_info (type);
- win_info->generic.type = type;
init_win_info (win_info);
return win_info;
@@ -654,7 +653,7 @@ tui_free_window (struct tui_win_info *win_info)
}
if (win_info->generic.title)
xfree (win_info->generic.title);
- xfree (win_info);
+ delete win_info;
}
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index c696feed280..34822e2a92d 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -271,6 +271,13 @@ struct tui_command_info
/* This defines information about each logical window. */
struct tui_win_info
{
+ tui_win_info (enum tui_win_type type)
+ {
+ generic.type = type;
+ }
+
+ DISABLE_COPY_AND_ASSIGN (tui_win_info);
+
struct tui_gen_win_info generic; /* General window information. */
union
{
--
2.17.2