This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 14/66] Introduce has_locator method

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 24 Jun 2019 14:50:51 -0600
Subject: Re: [PATCH 14/66] Introduce has_locator method
References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-15-tom@tromey.com> <a8f5e051-a2fe-8900-69fe-20cfac729884@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> -  int has_locator;		/* Does locator belongs to this window?  */
>> +  bool has_locator;		/* Does locator belongs to this window?  */

Pedro> I'd vote to fix the comment's grammar at the same time.

I did that.

>> +  /* Return true if this window has a locator.  */

Pedro> Should this "a locator" be "the locator", or ...

It should be "the locator", so I made this change.

Tom

References:
- [PATCH 00/66] Clean up the TUI
  - From: Tom Tromey
- [PATCH 14/66] Introduce has_locator method
  - From: Tom Tromey
- Re: [PATCH 14/66] Introduce has_locator method
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]