This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] arm-tdep: replace arm_mapping_symbol VEC with std::vector
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org, Alan Hayward <Alan dot Hayward at arm dot com>, Tom Tromey <tom at tromey dot com>
- Date: Tue, 25 Jun 2019 08:26:09 -0600
- Subject: Re: [PATCH 1/2] arm-tdep: replace arm_mapping_symbol VEC with std::vector
- References: <20190625013748.11003-1-simon.marchi@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> This patch replaces VEC (arm_mapping_symbol) with an std::vector. No
Simon> functional changes intended.
Thanks for doing this. I had a couple of nits, nothing serious.
Simon> struct arm_per_objfile
Simon> {
Simon> - VEC(arm_mapping_symbol_s) **section_maps;
Simon> + arm_per_objfile (size_t num_sections)
Should be explicit. Also probably this class should use
DISABLE_COPY_AND_ASSIGN.
thanks,
Tom