This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed][gdb/testsuite] Add back missing debug for index-cache.exp
[ was: Re: Testcase regression (gdb.base/index-cache.exp) on x86_64
(was: Re: [PATCH][gdb/testsuite] Compile index-cache.c with
-Wl,--build-id) ]
On 25-06-19 21:06, Sergio Durigan Junior wrote:
> On Friday, June 21 2019, Tom de Vries wrote:
>
>> Thanks for the review, I've updated the rationale.
>>
>> I'll commit in a bit unless there are further comments.
>
> Hi Tom,
>
> This has caused a testcase regression on x86_64. It was caught by the
> BuildBot:
>
> https://sourceware.org/ml/gdb-testers/2019-q2/msg06515.html
>
> The failures are:
>
> PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats
> PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created
> PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check index-cache stats
> PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there
>
Fixed by patch attached below.
Committed.
Thanks,
- Tom
[gdb/testsuite] Add back missing debug for index-cache.exp
The proc prepare_for_testing has "debug" as default argument for the options
parameter.
In the commit c596f180a1 "[gdb/testsuite] Compile index-cache.c with
-Wl,--build-id", by setting the options argument we've effectively dropped
"debug". This causes index-cache.exp to not contain any debug info anymore on
most systems (though not on openSUSE), which causes index-cache.exp FAILs.
Fix this by adding back the missing "debug" option.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2019-06-26 Tom de Vries <tdevries@suse.de>
* gdb.base/index-cache.exp: Add back missing debug option.
---
gdb/testsuite/gdb.base/index-cache.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
index 6f1488e037..f14cbb01ef 100644
--- a/gdb/testsuite/gdb.base/index-cache.exp
+++ b/gdb/testsuite/gdb.base/index-cache.exp
@@ -19,7 +19,7 @@
standard_testfile
if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
- {additional_flags=-Wl,--build-id}] } {
+ {debug additional_flags=-Wl,--build-id}] } {
return
}