This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks


>> GDB is prefering this minsym over the the name provided by the
>> DWARF info due to some really old code in GDB which handles
>> "certain pathological cases".  See the first big block comment
>> in find_frame_funname for more information.

Pedro> Yuck!

>> I considered removing the code for this corner case entirely, but it
>> seems as though it might still be useful, so I left it intact.

Pedro> Yeah, I'd be inclined to try removing it too.  The comment
Pedro> smells of a.out or stabs limitations.  But I'm not 100% sure,
Pedro> and I'm sympathetic with forward incremental progress.

That code dates to the creation of the sourceware repository.

I think it could be deleted.  And, if it's still a bug somehow, it seems
better to fix it some other way, and not let stabs and/or a.out
weirdness into the generic code.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]