This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add an Objfile.lookup_global_symbol function

From: Eli Zaretskii <eliz at gnu dot org>
To: Tom Tromey <tom at tromey dot com>
Cc: cbiesinger at google dot com, gdb-patches at sourceware dot org
Date: Thu, 27 Jun 2019 05:35:49 +0300
Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
References: <20190625220832.247935-1-cbiesinger@google.com> <83pnn0jr39.fsf@gnu.org> <87pnn03vmp.fsf@tromey.com>

> From: Tom Tromey <tom@tromey.com>
> Cc: Christian Biesinger <cbiesinger@google.com>,  gdb-patches@sourceware.org
> Date: Wed, 26 Jun 2019 15:05:34 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> >> +Searches for a global symbol by name in this objfile. Optionally, the
> Eli>                                                        ^^
> Eli> Two spaces between sentences (here and elsewhere in the patch),
> Eli> please.
> 
> I wonder whether the parameter names ought to be wrapped in @var{}.

It should, thanks for catching that.

References:
- [PATCH] Add an Objfile.lookup_global_symbol function
  - From: Christian Biesinger via gdb-patches
- Re: [PATCH] Add an Objfile.lookup_global_symbol function
  - From: Eli Zaretskii
- Re: [PATCH] Add an Objfile.lookup_global_symbol function
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]