This is the mail archive of the
gdb-prs@sources.redhat.com
mailing list for the GDB project.
Re: gdb/409: build failures for targets that should build with -Werror
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: nobody at sources dot redhat dot com
- Cc: gdb-prs at sources dot redhat dot com,
- Date: 14 Mar 2002 23:38:01 -0000
- Subject: Re: gdb/409: build failures for targets that should build with -Werror
- Reply-to: Andrew Cagney <ac131313 at cygnus dot com>
The following reply was made to PR gdb/409; it has been noted by GNATS.
From: Andrew Cagney <ac131313@cygnus.com>
To: Richard.Earnshaw@arm.com
Cc: rearnsha@arm.com, gdb-patches@sources.redhat.com,
gdb-gnats@sources.redhat.com
Subject: Re: gdb/409: build failures for targets that should build with -Werror
Date: Thu, 14 Mar 2002 15:37:36 -0500
> http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=409
>>
>> I suspect the real bug is in the gdb_realpath() code. It should
>> strongly prefer realpath() over canonicalize_file_name(). The latter is
>> (as you noticed) GNU centric - I think it comes from the HURD.
>>
>
>
> OK, so how about this patch. It fixes most of the multi-build failures.
>
> <date> Richard Earnshaw <rearnsha@arm.com>
>
> * utils.c (gdb_realpath): Prefer realpath() over
> canonicalize_file_name().
>
Yes.
Can you also please add a comment indicating that
cannonicalize_file_name() allocates its buffer using malloc() (I just
looked at the glibc source).
Andrew