This is the mail archive of the
gdb-prs@sources.redhat.com
mailing list for the GDB project.
gdb/659: Allow ``return small-struct'' command
- From: ac131313 at redhat dot com
- To: gdb-gnats at sources dot redhat dot com
- Date: 19 Aug 2002 15:59:39 -0000
- Subject: gdb/659: Allow ``return small-struct'' command
- Reply-to: ac131313 at redhat dot com
>Number: 659
>Category: gdb
>Synopsis: Allow ``return small-struct'' command
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Mon Aug 19 09:08:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: ac131313@redhat.com
>Release: 2002-08-19
>Organization:
>Environment:
>Description:
The file values.c contains:
void
set_return_value (struct value *val)
{
struct type *type = check_typedef (VALUE_TYPE (val));
register enum type_code code = TYPE_CODE (type);
if (code == TYPE_CODE_ERROR)
error ("Function return type unknown.");
if (code == TYPE_CODE_STRUCT
|| code == TYPE_CODE_UNION) /* FIXME, implement struct return. */
error ("GDB does not support specifying a struct or union return value.");
STORE_RETURN_VALUE (type, VALUE_CONTENTS (val));
}
The ``code == struct || union'' test should be changed to use USE_STRUCT_CONVENTION(). That way, for ABIs that return small structs in registers, the STORE_RETURN_VALUE could store structs.
This still leaves return values which are using an address, but that is another problem.
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted: