This is the mail archive of the
gdb-prs@sourceware.org
mailing list for the GDB project.
breakpoints/2142: debug target has incorrect remove_watchpoint implementation
- From: petr at vmware dot com
- To: gdb-gnats at sources dot redhat dot com
- Date: 2 Jul 2006 21:55:51 -0000
- Subject: breakpoints/2142: debug target has incorrect remove_watchpoint implementation
- Reply-to: petr at vmware dot com
>Number: 2142
>Category: breakpoints
>Synopsis: debug target has incorrect remove_watchpoint implementation
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: patch
>Submitter-Id: net
>Arrival-Date: Sun Jul 02 21:58:01 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: petr@vmware.com
>Release: unknown-1.0
>Organization:
>Environment:
>Description:
Hello,
while working on putting i386 watchpoint/hwbreakpoints into target vector I've noticed that debug target for remove_watchpoint incorrectly calls insert_watchpoint. It does not seem to be right thing to do.
>How-To-Repeat:
>Fix:
Attached patch should fix problem.
Thanks, Petr Vandrovec
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/x-patch; name="gdb-fix-remove-watchpoint.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="gdb-fix-remove-watchpoint.diff"
ZGlmZiAtdWRyTiBnZGIub3JpZy9nZGIvdGFyZ2V0LmMgZ2RiL2dkYi90YXJnZXQuYwotLS0gZ2Ri
Lm9yaWcvZ2RiL3RhcmdldC5jCTIwMDYtMDUtMDUgMjI6MDg6NDUuMDAwMDAwMDAwICswMjAwCisr
KyBnZGIvZ2RiL3RhcmdldC5jCTIwMDYtMDctMDIgMjM6NDc6NDQuMDAwMDAwMDAwICswMjAwCkBA
IC0yMjA0LDEwICsyMjA0LDEwIEBACiB7CiAgIGludCByZXR2YWw7CiAKLSAgcmV0dmFsID0gZGVi
dWdfdGFyZ2V0LnRvX2luc2VydF93YXRjaHBvaW50IChhZGRyLCBsZW4sIHR5cGUpOworICByZXR2
YWwgPSBkZWJ1Z190YXJnZXQudG9fcmVtb3ZlX3dhdGNocG9pbnQgKGFkZHIsIGxlbiwgdHlwZSk7
CiAKICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLAotCQkgICAgICAidGFyZ2V0X2lu
c2VydF93YXRjaHBvaW50ICgweCVseCwgJWQsICVkKSA9ICVsZFxuIiwKKwkJICAgICAgInRhcmdl
dF9yZW1vdmVfd2F0Y2hwb2ludCAoMHglbHgsICVkLCAlZCkgPSAlbGRcbiIsCiAJCSAgICAgICh1
bnNpZ25lZCBsb25nKSBhZGRyLCBsZW4sIHR5cGUsICh1bnNpZ25lZCBsb25nKSByZXR2YWwpOwog
ICByZXR1cm4gcmV0dmFsOwogfQo=