This is the mail archive of the gdb@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: -Wmissing-prototypes ...


>>>>> Eli Zaretskii writes:

>> My current list is:
>> 
>> --enable-build-warnings=-Werror\
>> ,-Wimplicit\
>> ,-Wreturn-type\
>> ,-Wcomment\
>> ,-Wtrigraphs\
>> ,-Wformat\
>> ,-Wparentheses\
>> ,-Wpointer-arith\
>> ,-Wmissing-prototypes\
>> ,-Woverloaded-virtual\
[...]
Eli> Here are the patches for go32-nat.c to allow it to compile with all
Eli> kinds of -Wfoo switches (I added switches beyond those mentioned above).

Eli> +static void print_387_status (unsigned, struct env387 *);
Shouldn't this be unsigned int?  AFAIK the new ISO C99 standard
mandates it - and it doesn't harm here.

Eli>  static void
Eli> -print_387_status (unsigned short status, struct env387 *ep)
Eli> +print_387_status (unsigned status, struct env387 *ep)
Again: unsigned int
Eli> +  print_387_control_word ((unsigned)ep->control & 0xffff);
unsigned int

I didn't look at the rest,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]