Re: fwd: fixing some FIXMEs

[Christopher Faylor <cgf at redhat dot com>]

On Mon, Jan 08, 2001 at 09:04:32PM -0500, Phil Edwards wrote:
>
>I ran into these two FIXMEs in the top-level configury.  The one which
>tests the host is moved into the per-host section, and the one which sets
>up GDB_TK is moved into the per-target section.
>
>Opinions?  Comments?  This would need to be committed in both the src and
>gcc repositories, I believe, but since the patch deals with GDB/Insight,
>it was suggested that it be hashed over here first.

The changes make sense to me, except for the "Moved from configure"
comment.  That will just be puzzling to someone who stumbles across it,
I think.

cgf

>
>Index: configure
>===================================================================
>RCS file: /cvs/gcc/gcc/configure,v
>retrieving revision 1.33
>diff -u -3 -r1.33 configure
>--- configure	2001/01/02 15:44:40	1.33
>+++ configure	2001/01/09 00:21:16
>@@ -1069,21 +1069,6 @@
> export CFLAGS
> export CXXFLAGS
> 
>-# FIXME: This should be in configure.in, not configure
>-case "$host" in
>-	*go32*)
>-	    enable_gdbtk=no ;;
>-	*msdosdjgpp*)
>-	    enable_gdbtk=no ;;
>-esac
>-
>-# FIXME: This should be in configure.in, not configure
>-# Determine whether gdb needs tk/tcl or not.
>-if [ "$enable_gdbtk" != "no" ]; then
>-	GDB_TK="all-tcl all-tk all-itcl all-tix all-libgui"
>-else
>-	GDB_TK=""
>-fi
> 
> for subdir in . ${subdirs} ; do
> 
>Index: configure.in
>===================================================================
>RCS file: /cvs/gcc/gcc/configure.in,v
>retrieving revision 1.84
>diff -u -3 -r1.84 configure.in
>--- configure.in	2001/01/02 15:36:25	1.84
>+++ configure.in	2001/01/09 00:21:16
>@@ -277,6 +277,14 @@
>   fi
> fi
> 
>+# Moved from configure.
>+case "$host" in
>+  *go32*)
>+    enable_gdbtk=no ;;
>+  *msdosdjgpp*)
>+    enable_gdbtk=no ;;
>+esac
>+
> # We default to --with-shared on platforms where -fpic is meaningless.
> # Well, we don't yet, but we will.
> if false && [ "${host}" = "${target}" ] && [ x${enable_shared} = x ]; then
>@@ -974,6 +982,14 @@
>   use_gnu_as=no
>   noconfigdirs="$noconfigdirs gas"
> fi
>+
>+# Determine whether gdb needs tk/tcl or not.  Moved from configure.
>+if [ "$enable_gdbtk" != "no" ]; then
>+  GDB_TK="all-tcl all-tk all-itcl all-tix all-libgui"
>+else
>+  GDB_TK=""
>+fi
>+
> 
> # Figure out what language subdirectories are present.
> # Look if the user specified --enable-languages="..."; if not, use
>

-- 
cgf@cygnus.com                        Red Hat, Inc.
http://sources.redhat.com/            http://www.redhat.com/