This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Multi-arching FLOAT_INFO


> + void
>> > + default_float_info (void)
>> > + {
>> > + #ifdef FLOAT_INFO
>> > + #if GDB_MULTI_ARCH
>> > + #error "FLOAT_INFO defined in multi-arch"
> 
>> 
>> 
>> Suggest #if GDB_MULTI_ARCH > GDB_MULTI_ARCH_PARTIAL
> 
> 
> But surely a multi-arch (even a partial multi-arch) should be using the 
> new function, not the old one.  I thought it was ok to be using 
> legacy-style definitions of multi-arch macros, but not to be using 
> deprecated ones (hence the error).  If that is incorrect of course, I can 
> easily change it as you suggest.


It is a compromize.  GDB_MULTI_ARCH_TM and above do what you describe. 
GDB_MULTI_ARCH_PARTIAL is intentionally lax about what it allows, only 
barfing a build when absolutly necessary.  The intention is to make the 
steps necessary before adding #define GDB_MULTI_ARCH 
GDB_MULTI_ARCH_PARTIAL as minimal as possible.  Since you've fixed the 
frame stuff, can I suggest skipping to the step where the above is defined.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]