Re: zillions of testsuite failures

[Elena Zannoni <ezannoni at redhat dot com>]

David Carlton writes:
 > On Wed, 15 Jan 2003 19:50:08 -0500, Elena Zannoni <ezannoni@redhat.com> said:
 > 
 > > try this for the first problem (args.exp), it seems to work for me, if
 > > it works for you too I'll check it in.
 > 
 > Yeah, it works for me.
 > 

I checked that in.

 > Though, interestingly, more of the zillions of failures were real than
 > I thought: besides the aforementioned advance.exp failures, I'm also
 > seeing failures on:
 > 
 > FAIL: gdb.base/break.exp: break on default location, 2nd time
 > FAIL: gdb.base/break.exp: break on default location, 3rd time
 > FAIL: gdb.base/break.exp: break on default location, 4th time
 > 

I really didn't pay enough attention. Sorry.
This is a weird one. Since I removed the 'until' tests from before these
'set breakpoint at default location' tests, the default location has changed,
and so the tests are failing.

 > I'll include the log in my signature.
 > 
 > And the two "help until" tests in gdb.base/help.exp are failing; maybe
 > they're looking for the old text.  (Should there also be a "help
 > advance" test added?)  And gdb.base/until.exp gives me this; gdb.log
 > fragment after my signature.

Grunt. Not my day.
I'll post a patch right away.


 > 
 > PASS: gdb.base/until.exp: until line number
 > PASS: gdb.base/until.exp: malformed until
 > FAIL: gdb.base/until.exp: until factorial, recursive function
 > FAIL: gdb.base/until.exp: until func, not called by current frame
 >

This seems to be caused by the different source file that gets printed
in your gdb.log, like for advance.exp.
 
 > (gdb) until 99
 > factorial (value=720) at gdb.base/break.c:99
 > 99	    return (value);
 > (gdb) FAIL: gdb.base/until.exp: until factorial, recursive function
 > delete breakpoints
 > (gdb) info breakpoints
 > No breakpoints or watchpoints.
 > (gdb) break marker2
 > Breakpoint 3 at 0x80484fd: file gdb.base/break.c, line 49.
 > (gdb) run 
 > The program being debugged has been started already.
 > Start it from the beginning? (y or n) y
 > Starting program: /extra/gdb/mirror/src/gdb/testsuite/gdb.base/break 
 > 720
 > 
 > Breakpoint 3, 0x080484fd in marker2 (a=43) at gdb.base/break.c:49
 > 49	int marker2 (a) int a; { return (1); }
 > (gdb) delete breakpoints
 > Delete all breakpoints? (y or n) y
 > (gdb) info breakpoints
 > No breakpoints or watchpoints.
 > (gdb) until marker3
 > main (argc=1, argv=0xbffff134, envp=0xbffff13c) at gdb.base/break.c:83
 > 83	    marker3 ("stack", "trace");
 > (gdb) FAIL: gdb.base/until.exp: until func, not called by current frame
 > testcase ./gdb.base/until.exp completed in 2 seconds


I get:

(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until 99
factorial (value=720) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:99
99          return (value);
(gdb) PASS: gdb.base/until.exp: until factorial, recursive function
delete breakpoints
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) break marker2
Breakpoint 3 at 0x804850f: file /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c, line 49.
(gdb) run 
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ezannoni/sources/native/gdb/testsuite/gdb.base/break 
720

Breakpoint 3, 0x0804850f in marker2 (a=43) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:49
49      int marker2 (a) int a; { return (1); }
(gdb) delete breakpoints
Delete all breakpoints? (y or n) y
(gdb) info breakpoints
No breakpoints or watchpoints.
(gdb) until marker3
0x08048593 in main (argc=1, argv=0xbfffd974, envp=0xbfffd97c) at /home/ezannoni/sources/src/gdb/testsuite/gdb.base/break.c:82
82          marker2 (43);
(gdb) PASS: gdb.base/until.exp: until func, not called by current frame
testcase /home/ezannoni/sources/src/gdb/testsuite/gdb.base/until.exp completed in 4 seconds