This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: remove enum from ppc-linux-tdep.c


On Sun, Jan 26, 2003 at 08:20:55PM +0100, Olaf Hering wrote:
> Hi,
> 
> this patch uses the defines from asm/elf.h instead of the hardcoded
> values. Would that have any bad side effects? asm-ppc64 includes elf.h
> via sigcontext.h and that will result in a syntax error.


> +#include "<asm/elf.h>"

First of all, that's a syntax error :)

Secondly, tdep stands for target dependant.  This needs to work from
any host platform.  The right thing to do is probably to rename the
enum: PPC_LINUX_ELF_NGREG, or something like that.

[Or fix your headers.  That's pretty bad namespace polution.  It
shouldn't do that.]

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]