This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gdb.mi/mi-cli.exp failures

From: Andrew Cagney <ac131313 at redhat dot com>
To: Andrew Cagney <ac131313 at redhat dot com>
Cc: David Carlton <carlton at math dot stanford dot edu>,gdb <gdb at sources dot redhat dot com>, binutils at sources dot redhat dot com
Date: Mon, 31 Mar 2003 16:20:44 -0500
Subject: Re: gdb.mi/mi-cli.exp failures
References: <ro14r5j1g87.fsf@jackfruit.Stanford.EDU> <3E88A369.6090403@redhat.com> <3E88AE3F.4030005@redhat.com>

And this:

-	return concat (filename);
+	return filename;

(remembering that the patch is backwards) doesn't look so good. It should be:

concat (filename, NULL);

perhaps

xstrdup (filename)

would be easier to read :-)

Doesn't get gdb off the hook though.

Andrew

References:
- gdb.mi/mi-cli.exp failures
  - From: David Carlton
- Re: gdb.mi/mi-cli.exp failures
  - From: Andrew Cagney
- Re: gdb.mi/mi-cli.exp failures
  - From: Andrew Cagney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]