Re: msym->info is wack

[Andrew Cagney <ac131313 at redhat dot com>]

> Hi Andrew,
>
> mec> === ARM-TDEP.C, M68HC11-TDEP.C, MIPS-TDEP.C, SH-TDEP.C
> mec> 
> mec> These *-tdep.c files use msym->info as a place to store flag bits.
> mec> So, first, they are converting 'void *' to 'long' and back again.
>
> ac> Begs the question, is the field needed -> can bfd provide the info directly?
>
> I don't know.
>
> My point of view is "incremental improvement from status quo".  From
> that point of view, changing "set flag bit in void *" to "set flag bit
> in minsym->tdep_flags" is an improvement.  It makes it easier, not
> harder, to change the tdep code later, if desired.

I can see that.  It's also important to take a look around at what is 
really happening.  Otherwize the small incremental improvements miss the 
mark.

Thinking about it, only 1 or 2 of those bazillion marked up minimal 
symbols will ever get used.  So why is the code even marking them up - 
leave it to run time.  It will make the minimal symbol smaller, it will 
speed up the load (although I suspect that on both counts the 
measurement isn't there).

Andrew