This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Line number fix for prologues
- From: Richard Henderson <rth at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, gdb at sources dot redhat dot com
- Date: Fri, 16 Jan 2004 12:12:38 -0800
- Subject: Re: RFA: Line number fix for prologues
- References: <20040116153601.GA28489@nevyn.them.org>
On Fri, Jan 16, 2004 at 10:36:01AM -0500, Daniel Jacobowitz wrote:
> My silly question is, does that emit_nop () even serve any purpose? I
> imagine it was there to make the loop optimizer happy once upon a time ...
Actually, I think it's for debugging. Certainly the loop optimizer
won't care one way or the other. If you can show that gdb works as
well or better without that nop (both dwarf and stabs) then I think
that's ample reason to remove it.
> * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define.
> (final_scan_insn): Update to take an additional SEEN argument. Emit
> a line note after the prologue. Make static.
> (line_note_exists): Remove.
> (final): Don't initialize line_note_exists. Update call to
> final_scan_insn.
> * output.h (final_scan_insn): Remove prologue.
> * function.c (set_insn_locators): Update comment.
> (thread_prologue_and_epilogue_insns): Add a comment.
Ok.
r~