This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: MI-related testsuite regressions
> > -i=mi sets mi_version to 2 in my copy:
> >
> > interp_add (interp_new (INTERP_MI, NULL, mi_out_new (2), &procs));
> >
> > and
> >
> > if (current_interp_named_p (INTERP_MI1))
> > deprecated_command_loop_hook = mi1_command_loop;
> > else if (current_interp_named_p (INTERP_MI2))
> > deprecated_command_loop_hook = mi2_command_loop;
> > else if (current_interp_named_p (INTERP_MI3))
> > deprecated_command_loop_hook = mi3_command_loop;
> > else
> > deprecated_command_loop_hook = mi2_command_loop;
> >
> >
> > As far as I can see mi3 does nothing that mi2 doesn't do.
>
> I think the ideology is that mi3 is allowed to change in such a way that
> mi2 is not. So, all new features go into mi3, while mi2 should remain
> stable and unchanged, except for bug fixes and minor new improvements
> that are backwards compatible.
If thats the case, shouldn't the code read:
interp_add (interp_new (INTERP_MI, NULL, mi_out_new (3), &procs));
and
if (current_interp_named_p (INTERP_MI1))
deprecated_command_loop_hook = mi1_command_loop;
else if (current_interp_named_p (INTERP_MI2))
deprecated_command_loop_hook = mi2_command_loop;
else if (current_interp_named_p (INTERP_MI3))
deprecated_command_loop_hook = mi3_command_loop;
else
deprecated_command_loop_hook = mi3_command_loop;
as it stands the mi-*.exp don't test mi3.
Nick