This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MI error msgs and localization


On Wed, Feb 15, 2006 at 02:46:53PM +1300, Nick Roberts wrote:
> That's not quite what I said but it's a better idea as fewer changes need be
> made.  Better still might be to use a global variable, perhaps
> mi_error_message in mi-main.c could be used.  How about something like the
> patch below (in mi_execute_command) to be used like this:
> 
>   mi_error_message = xstrprintf ("no-debugging-symbols");
>   error(_("No debugging symbols found");
> 
> to give:
> 
>   &"No debugging symbols found\n"
>   ^error,msg="no-debugging-symbols"

Please don't.  If you need to pass two arguments to error, make a
two-argument version :-)

Passing arguments by globals is bad news.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]