This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: PAGE_SIZE Availability Inconsistency
- From: Christoph Hellwig <hch at infradead dot org>
- To: Arjan van de Ven <arjan at infradead dot org>
- Cc: Christoph Hellwig <hch at infradead dot org>, Roman Zippel <zippel at linux-m68k dot org>, David Brown <dmlb2000 at gmail dot com>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, gdb at sourceware dot org
- Date: Thu, 8 Mar 2007 16:08:52 +0000
- Subject: Re: PAGE_SIZE Availability Inconsistency
- References: <9c21eeae0703051555x1884fd7cse7968a71ec04eb27@mail.gmail.com> <20070306092917.GA5226@infradead.org> <200703080318.04631.zippel@linux-m68k.org> <20070308090031.GB7373@infradead.org> <1173369229.3550.2.camel@laptopd505.fenrus.org>
On Thu, Mar 08, 2007 at 07:53:49AM -0800, Arjan van de Ven wrote:
> > > > PAGE_SIZE should not be available at all. Please use getpagesize()
> > > > instead.
> > >
> > > While I agree, NBPG is a bit of a problem, although it's only needed for aout
> > > coredumps AFAICT, but still needed to compile e.g. gdb.
> >
> > So we should export this one with an arbitrary value (on multiple page
> > size architectures) and a warning, maybe even an __deprecated attached to
> > it.
>
> if we think the kernel should export this one, we could do
>
> #ifndef __KERNEL__
> #define PAGE_SIZE getpagesize()
> #endif
No, no no. We should never export PAGE_SIZE. We might export NBPG
as deprecated symbol for gdb if it really needs it, but that should
happen only on a.out systems, and it it should be a true constant,
not depending on PAGE_SIZE.
I've Cc'ed the gdb list on whether they have any comments on this
issue.