This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Removing -Wunused warnings
- From: Tom Tromey <tromey at redhat dot com>
- To: "Philip Lee \(IDEAS\)" <Phil dot Lee at morganstanley dot com>
- Cc: gdb at sources dot redhat dot com
- Date: Thu, 02 Jul 2009 08:32:59 -0600
- Subject: Re: Removing -Wunused warnings
- References: <fe6bf5dc0907011254h3b81b354p33d3a1f5bf343b31@mail.gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> "Phil" == Philip Lee (IDEAS) <Phil.Lee@morganstanley.com> writes:
Phil> I thought I'd see if I can remove at least some of the 'unused
Phil> variable' warnings generated when compiling with -Wunused. I haven't
Phil> committed any code before and I figure that's a good way to figure out
Phil> the build system and code layout.
Sounds good.
Phil> I've had a read of the CONTRIBUTING page, but if someone could ping me
Phil> as to whether it's better to submit one patch or a series of them and
Phil> anything else I'm likely to get wrong I'd appreciate it.
Bigger patches are harder to review. So, you're likely to get a
response more quickly to smaller patches.
Do you have your copyright assignment in place? If not, contact me
and I will get you started. It is good to get this out of the way
early.
The usual stuff people get wrong is formatting nits -- read the GNU
coding standards, especially the stuff about formatting C and the
stuff about writing ChangeLog entries.
Tom