This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
RE: [RFC] ARI related: Use of GCC poison pragma
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb at sourceware dot org>
- Date: Thu, 15 Nov 2012 17:25:08 +0100
- Subject: RE: [RFC] ARI related: Use of GCC poison pragma
- References: <009b01cdc30f$c7684e80$5638eb80$@muller@ics-cnrs.unistra.fr> <20121115151350.GB3806@adacore.com>
> -----Message d'origine-----
> De?: gdb-owner@sourceware.org [mailto:gdb-owner@sourceware.org] De la part
> de Joel Brobecker
> Envoyé?: jeudi 15 novembre 2012 16:14
> À?: Pierre Muller
> Cc?: gdb@sourceware.org
> Objet?: Re: [RFC] ARI related: Use of GCC poison pragma
>
> > To avoid resurgence of expunged ARI problems,
> > Pedro suggested the use of GCC poison pragma.
Yes, Pedro talked about simply removing the
function completely.
> I believe it was Tom, actually.
and Tom suggested use of poison pragma.
> > What would be the corresponding gdb file? I suppose it would be
> > defs.h
>
> I agree that defs.h should be a good place for it.
>
> > So would a patch adding
> > #if (GCC_VERSION >= 3000)
> > #pragma GCC poison xvasprintf
> > #endif
>
> I don't think we really need the GCC_VERSION check, do we?
I still think that this should only be
parsed by GCC.
So a conditional to restrict to GCC compiler is needed,
but I suppose you meant that the use of a GCC prior to 3000
is not needed...
Pierre