This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch gdb]: Fix display for LLP64 target in window-nat.c


> You should use %s & host_address_to_string instead of %p &
> the various casts. So the following should work:
> 
>       DEBUG_MEM (("gdb: write target memory, %d bytes at 0x%s\n",
> 		  len, host_address_to_string (memaddr)));
> 
> OK with that change.

Actually, I was confused. Sorry. Try either core_addr_to_string_nz
(or core_addr_to_string if you want leading zeros)...


> 
> > Index: windows-nat.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/windows-nat.c,v
> > retrieving revision 1.238
> > diff -p -u -r1.238 windows-nat.c
> > --- windows-nat.c	1 Jan 2013 06:41:29 -0000	1.238
> > +++ windows-nat.c	19 Feb 2013 14:05:20 -0000
> > @@ -2312,8 +2312,8 @@ windows_xfer_memory (CORE_ADDR memaddr,
> >    SIZE_T done = 0;
> >    if (write)
> >      {
> > -      DEBUG_MEM (("gdb: write target memory, %d bytes at 0x%08lx\n",
> > -		  len, (DWORD) (uintptr_t) memaddr));
> > +      DEBUG_MEM (("gdb: write target memory, %d bytes at 0x%p\n",
> > +		  len, (LPVOID) (uintptr_t) memaddr));
> >        if (!WriteProcessMemory (current_process_handle,
> >  			       (LPVOID) (uintptr_t) memaddr, our,
> >  			       len, &done))
> > @@ -2323,8 +2323,8 @@ windows_xfer_memory (CORE_ADDR memaddr,
> >      }
> >    else
> >      {
> > -      DEBUG_MEM (("gdb: read target memory, %d bytes at 0x%08lx\n",
> > -		  len, (DWORD) (uintptr_t) memaddr));
> > +      DEBUG_MEM (("gdb: read target memory, %d bytes at 0x%p\n",
> > +		  len, (LPVOID) (uintptr_t) memaddr));
> >        if (!ReadProcessMemory (current_process_handle,
> >  			      (LPCVOID) (uintptr_t) memaddr, our,
> >  			      len, &done))
> 
> -- 
> Joel

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]