This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Trailing Whitespace
- From: Dmitry Samersoff <dms at samersoff dot net>
- To: Joel Brobecker <brobecker at adacore dot com>, Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb at sourceware dot org
- Date: Thu, 09 Jan 2014 22:46:19 +0400
- Subject: Re: Trailing Whitespace
- Authentication-results: sourceware.org; auth=none
- References: <CA+XNFZP6JzmOGo=nQDd4kab8RK1zvR4sij_zgS7qdPw7C1W9Vw at mail dot gmail dot com> <20140109144455 dot GA2972 at blade dot nx> <20140109145731 dot GA13720 at localhost dot localdomain> <20140109150145 dot GA3788 at adacore dot com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
IMHO, better approach is to install on-commit hook blocking commits
with trailing whitespace (and tab characters) and leave old code as is.
On 2014-01-09 19:01, Joel Brobecker wrote:
>> Also (and I am not sure if git can get around this somehow)
>> whitespace cleanups tend to obliterate diffs/patches that were
>> written before the cleanup took place. This makes merging a
>> massive pain.
>>
>> So my 2 pence worth is, no, not a good idea ;)
>
> Strongly seconded. Localized whitespace fixes are OK, because
> manageable in the amount of work they generate, but please, not a
> massive cleanup. And if we ever do that massive cleanup, I would
> request that a pre-requisite is an "update" check on the git server
> that rejects pushes of files violating that rule.
>
> On my end of things, I configured my editor to simply highlight
> trailing spaces, not strip them.
>
- --
Dmitry Samersoff
Saint Petersburg, Russia, http://devnull.samersoff.net
* There will come soft rains ...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJSzu57AAoJEHEy08c4gIABafIH/RMOU8+mzZts8yRFUKHKB1D/
89sG/dfLWTShhJoK4omD9h4BzntQgzBviyhEsQuaAgYATg+3Ok503wd+WhEEkVub
IqqXoz4Pu/2GSu2sWzNT9o+sXudUH/gyGsG+/ISVsBr1yF7WMSUMl8TLeOTJMUi6
hY/7lrBfNVFxEnKXS94sdf98dXCz1oGWQXDt9zv26zeayhKjMx41A11IQTZN5Lrd
yMdyd4O4/r+9T6otii1utnDTQwYfRGiOb+UFoE7bD+blEL5pqSDLHsYcXpmnvhXE
sAc3Koa33KimE6krJsFoKSZPDxXbefb/48e959VqF6/1Nh1/qxWmY6lonqHA0Rg=
=2WWt
-----END PGP SIGNATURE-----