This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Why wasn't this patch applied
- From: Gary Benson <gbenson at redhat dot com>
- To: Programmingkid <programmingkidx at gmail dot com>
- Cc: gdb at sourceware dot org, Hui Zhu <hui_zhu at mentor dot com>
- Date: Mon, 9 Jun 2014 10:50:47 +0100
- Subject: Re: Why wasn't this patch applied
- Authentication-results: sourceware.org; auth=none
- References: <332D2FE6-D4B1-4D16-A0B3-D2019050DF42 at gmail dot com> <E67A59F4-CA54-42F7-A09E-91C825793B7B at gmail dot com>
Programmingkid wrote:
> --- a/gdb/python/py-framefilter.c
> +++ b/gdb/python/py-framefilter.c
> @@ -1506,7 +1506,10 @@ apply_frame_filter (struct frame_info *f
> initialization error. This return code will trigger a
> default backtrace. */
>
> - gdbpy_print_stack ();
> + if (gdb_python_module != NULL)
> + gdbpy_print_stack ();
> + else
> + PyErr_Clear ();
> do_cleanups (cleanups);
> return PY_BT_NO_FILTERS;
> }
>
> This patch fixes this error message problem printed when a backtrace
> takes place:
>
> Python Exception <type 'exceptions.ImportError'> No module named gdb.frames:
>
> I found it here:
> http://www.sourceware.org/ml/gdb-patches/2013-11/msg00881.html
>
> It was made available about half a year ago but still hasn't been
> applied. Is there a reason it hasn't been applied yet? I have tried
> it myself and it does work.
Possibly it got forgotten. GDB's review process can be slow at times,
and things often slip through the cracks.
I've Cc'd Hui, perhaps he can shed some light on this.
Thanks,
Gary
--
http://gbenson.net/