This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/1060] sysdeps/generic/glob.c merge from gnulib (part 1 of 3)


------- Additional Comments From derek at ximbiot dot com  2005-09-09 01:42 -------
I think it will be fine.  Now that <glob.h> is included first, it's definitions
for the GLOB_* macros should take precedence, unless the headers that
"erroneously define" them do something extremely bad, like #undeffing them first
or failing to protect their definitions with #ifndef GLOB_WHATEVER, but I say
that bridge would best be crossed when we get to it.

The ChangeLog message was probably slightly inaccurate.  How about this
corercted one (I only changed the one sentence)?

2005-07-11  Derek Price  <derek@ximbiot.com>
        and Paul Eggert  <eggert@cs.ucla.edu>

    * sysdeps/generic/glob.c:  Update copyright.  Assume freestanding
    C89 compiler.  Simplify cruft that may be replaced with GNULIB
    modules.  Make no attempt to find 64-bit versions of file access
    functions directly when !_LIBC.  Avoid undef'ing GLOB_* macros by
    #including <glob.h> before potentially offending headers.
    (DIRENT_MUST_BE, DIRENT_MIGHT_BE_SYMLINK, DIRENT_MIGHT_BE_DIR): New
    macros to abstract dirent->d_type access.
    (GETPW_R_SIZE_MAX, GET_LOGIN_NAME_MAX): New macros to abstract sysconf
    access.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1060

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]