This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/686] [localedef] Implement toggle switches in LC_COLLATE section


------- Additional Comments From madcoder at debian dot org  2007-10-27 13:06 -------
(In reply to comment #3)
> I cannot imagine that this patch works and it is overkill.
> I've implemented a very simple preprocessor now which should do the trick.

It did work actually, and yours doesn't and generate a 100%CPU in 
locale/program/ld-collate.c:

4032:         while (curdef != NULL) 
                if (strncmp (arg->val.str.startmb, curdef->str, 
                             arg->val.str.lenmb) == 0 
                    && curdef->str[arg->val.str.lenmb] == '\0') 
                  break; 

I suppose the correct fix is to add a:
                else 
                  curdef = curdef->next; 


For the sake of completeness, I'll also attach Denis patch that was in 
production in debian since glibc 2.3.6 and works.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=686

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]