This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/6845] New: Remove redundant PowerPC bits/mathinline.h


There are two versions of mathinline.h

sysdeps/powerpc/fpu/bits/mathinline.h
sysdeps/unix/sysv/linux/powerpc/bits/mathinline.h

Here's a diff between them.  They're the same except for some recent additions
to the deeper file.

--- ./sysdeps/powerpc/fpu/bits/mathinline.h	2008-08-14 21:27:55.000000000 -0500
+++ ./sysdeps/unix/sysv/linux/powerpc/bits/mathinline.h	2008-08-14
21:27:55.000000000 -0500
@@ -1,5 +1,5 @@
 /* Inline math functions for powerpc.
-   Copyright (C) 1995, 1996, 1997, 1998, 1999, 2000, 2004, 2006, 2007
+   Copyright (C) 1995, 1996, 1997, 1998, 1999, 2000, 2004, 2006, 2007, 2008
    Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
@@ -72,6 +72,14 @@
   __extension__ union { double __d; int __i[2]; } __u = { __d: __x };
   return __u.__i[0] < 0;
 }
+#  ifdef __LONG_DOUBLE_128__
+__MATH_INLINE int
+__NTH (__signbitl (long double __x))
+{
+  __extension__ union { long double __d; int __i[4]; } __u = { __d: __x };
+  return __u.__i[0] < 0;
+}
+#  endif
 # endif
 #endif /* __USE_ISOC99 */

Even though the macros are guarded by !defined _SOFT_FLOAT we generally like to
keep any file with floating point assembler operations in a powerpc/fpu
directory.  So I think it's better to go with the shallower version and move the
recent changes there and then remove the deeper one.  Patch forthcoming.

-- 
           Summary: Remove redundant PowerPC bits/mathinline.h
           Product: glibc
           Version: 2.8
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: rsa at us dot ibm dot com
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: powerpc64-linux
  GCC host triplet: powerpc64-linux
GCC target triplet: powerpc64-linux


http://sourceware.org/bugzilla/show_bug.cgi?id=6845

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]