This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/13673] fix for incorrect FSF snail mail addresses


http://sourceware.org/bugzilla/show_bug.cgi?id=13673

--- Comment #5 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2012-02-09 23:25:56 UTC ---
I have reviewed the patch, as far as one can review a 100000-line patch, 
and committed most of it (all the changes would individually be considered 
obvious).  I omitted the following parts:

* config.sub, config.guess: these files should only ever be updated 
verbatim from upstream config.git, not changed locally.

* intl/plural.[cy], locale/programs/{charmap,locfile}-kw.{h,gperf}: it 
appears that the generated files in these pairs had just had the same 
substitution applied as the source files, which is not correct as a I 
think a regeneration would also change #line directives to reflect that 
the license notices are now one line shorter.

Several files had changes removing blank lines at the end of the file.  I 
left those changes in, but please try to avoid including such unrelated 
changes in future.

You may wish to do a followup to change the files with generated outputs 
correctly (actually regenerating the output) and to change files that are 
new since your first patch.  Also, perhaps you could share your automation 
for producing this patch so it can be used for ports, or do a 
corresponding patch for ports (where one file has the even older 675 Mass 
Ave address)?

Please also update gettext, GMP and libidn upstream with changes 
corresponding to those made in libc to files from those projects.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]