This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch, master, updated. glibc-2.15-551-ge80d6f9
- From: aj at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 5 Apr 2012 08:51:37 -0000
- Subject: GNU C Library master sources branch, master, updated. glibc-2.15-551-ge80d6f9
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via e80d6f94e19d17b91e3cd3ada7193cc88f621feb (commit)
via 349fa79f5527f78d60c78eb1fbb2dfb56846018c (commit)
from 6745ccf5a4b03a6565e7cc5b7e00e00a56cd440b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=e80d6f94e19d17b91e3cd3ada7193cc88f621feb
commit e80d6f94e19d17b91e3cd3ada7193cc88f621feb
Author: Michael Matz <matz@suse.de>
Date: Thu Apr 5 10:48:14 2012 +0200
Fix size parameter comparisions.
[BZ #13592]
There are several signed compares of the size argument, whereas
it really is unsigned. Depending on situations e.g. a "memset(ptr, 0,
-1)" segfault (but for the wrong reasons, because jumping into nirvana)
or succeeds even.
In normal use this is harmless, as a size with signbit set indicates
more than half the address space which on x86_64 is impossible to
allocate, but as the size is used to index some jump tables this
potentially could have other unwanted side effects.
diff --git a/ChangeLog b/ChangeLog
index 946c714..f934b34 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-04-05 Michael Matz <matz@suse.de>
+
+ [BZ #13592]
+ * sysdeps/x86_64/memset.S: Fix size paramater comparisions.
+
2012-04-05 Andreas Jaeger <aj@suse.de>
[BZ #13908]
diff --git a/NEWS b/NEWS
index 2f0e764..e20b5ec 100644
--- a/NEWS
+++ b/NEWS
@@ -15,11 +15,11 @@ Version 2.16
10110, 10135, 10140, 10210, 10346, 10545, 10716, 11174, 11322, 11365,
11451, 11494, 12047, 12340, 13058, 13525, 13526, 13527, 13528, 13529,
13530, 13531, 13532, 13533, 13547, 13551, 13552, 13553, 13555, 13559,
- 13566, 13583, 13618, 13637, 13656, 13658, 13673, 13691, 13695, 13704,
- 13706, 13726, 13738, 13760, 13761, 13786, 13792, 13806, 13824, 13840,
- 13841, 13844, 13846, 13851, 13852, 13854, 13871, 13879, 13883, 13892,
- 13908, 13910, 13911, 13912, 13913, 13915, 13916, 13917, 13918, 13919,
- 13920, 13921, 13926, 13928, 13938
+ 13566, 13583, 13592, 13618, 13637, 13656, 13658, 13673, 13691, 13695,
+ 13704, 13706, 13726, 13738, 13760, 13761, 13786, 13792, 13806, 13824,
+ 13840, 13841, 13844, 13846, 13851, 13852, 13854, 13871, 13879, 13883,
+ 13892, 13908, 13910, 13911, 13912, 13913, 13915, 13916, 13917, 13918,
+ 13919, 13920, 13921, 13926, 13928, 13938
* ISO C11 support:
diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.S
index 7be9071..9511745 100644
--- a/sysdeps/x86_64/memset.S
+++ b/sysdeps/x86_64/memset.S
@@ -1,6 +1,6 @@
/* memset/bzero -- set memory area to CH/0
Optimized version for x86-64.
- Copyright (C) 2002-2005, 2007, 2008, 2011 Free Software Foundation, Inc.
+ Copyright (C) 2002-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -52,7 +52,7 @@ L(ck2):
imul %r9,%rdx
L(now_dw_aligned):
cmp $0x90,%r8
- jg L(ck_mem_ops_method)
+ ja L(ck_mem_ops_method)
L(now_dw_aligned_small):
add %r8,%rdi
#ifndef PIC
@@ -604,7 +604,7 @@ L(aligned_now):
punpcklqdq %xmm0,%xmm0
cmp $0xb0,%r8 # 176
- jge L(byte32sse2_pre)
+ jae L(byte32sse2_pre)
add %r8,%rdi
# ifndef PIC
@@ -864,7 +864,7 @@ L(byte32sse2_pre):
mov __x86_64_shared_cache_size(%rip),%r9d # The largest cache size
cmp %r9,%r8
- jg L(sse2_nt_move_pre)
+ ja L(sse2_nt_move_pre)
#jmp L(byte32sse2)
.balign 16
L(byte32sse2):
@@ -880,7 +880,7 @@ L(byte32sse2):
movdqa %xmm0,0x70(%rdi)
lea 0x80(%rdi),%rdi
- jge L(byte32sse2)
+ jae L(byte32sse2)
add %r8,%rdi
# ifndef PIC
lea L(SSExDx)(%rip),%r11
@@ -914,7 +914,7 @@ L(sse2_nt_move):
movntdq %xmm0,0x70(%rdi)
lea 0x80(%rdi),%rdi
- jge L(sse2_nt_move)
+ jae L(sse2_nt_move)
sfence
add %r8,%rdi
# ifndef PIC
http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=349fa79f5527f78d60c78eb1fbb2dfb56846018c
commit 349fa79f5527f78d60c78eb1fbb2dfb56846018c
Author: Andreas Jaeger <aj@suse.de>
Date: Thu Apr 5 10:44:08 2012 +0200
Don't warn about unused result of mktemp
[BZ #13908]
mktemp always returns TEMPLATE, the caller should check TEMPLATE[0]
instead of TEMPLATE, so do not warn about the unused result.
Fix also the comment for mktemp
diff --git a/ChangeLog b/ChangeLog
index b7c05b6..946c714 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-04-05 Andreas Jaeger <aj@suse.de>
+
+ [BZ #13908]
+ * stdlib/stdlib.h: Don't warn about unused result of mktemp, fix
+ comment.
+
2012-04-05 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
* sysdeps/sh/sh4/fpu/fesetround.c (fesetround): Fix return value
diff --git a/NEWS b/NEWS
index 776867b..2f0e764 100644
--- a/NEWS
+++ b/NEWS
@@ -18,8 +18,8 @@ Version 2.16
13566, 13583, 13618, 13637, 13656, 13658, 13673, 13691, 13695, 13704,
13706, 13726, 13738, 13760, 13761, 13786, 13792, 13806, 13824, 13840,
13841, 13844, 13846, 13851, 13852, 13854, 13871, 13879, 13883, 13892,
- 13910, 13911, 13912, 13913, 13915, 13916, 13917, 13918, 13919, 13920,
- 13921, 13926, 13928, 13938
+ 13908, 13910, 13911, 13912, 13913, 13915, 13916, 13917, 13918, 13919,
+ 13920, 13921, 13926, 13928, 13938
* ISO C11 support:
diff --git a/stdlib/stdlib.h b/stdlib/stdlib.h
index d3bd492..4da4678 100644
--- a/stdlib/stdlib.h
+++ b/stdlib/stdlib.h
@@ -603,8 +603,9 @@ extern int clearenv (void) __THROW;
/* Generate a unique temporary file name from TEMPLATE.
The last six characters of TEMPLATE must be "XXXXXX";
they are replaced with a string that makes the file name unique.
- Returns TEMPLATE, or a null pointer if it cannot get a unique file name. */
-extern char *mktemp (char *__template) __THROW __nonnull ((1)) __wur;
+ Always returns TEMPLATE, it's either a temporary file name or a null
+ string if it cannot get a unique file name. */
+extern char *mktemp (char *__template) __THROW __nonnull ((1));
#endif
#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 11 +++++++++++
NEWS | 10 +++++-----
stdlib/stdlib.h | 5 +++--
sysdeps/x86_64/memset.S | 12 ++++++------
4 files changed, 25 insertions(+), 13 deletions(-)
hooks/post-receive
--
GNU C Library master sources