This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch release/2.19/master updated. glibc-2.19-68-g7a60958
- From: aurel32 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 19 Aug 2016 07:24:46 -0000
- Subject: GNU C Library master sources branch release/2.19/master updated. glibc-2.19-68-g7a60958
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, release/2.19/master has been updated
via 7a609588a02281638e9a0cb57bed18966806349a (commit)
from 9d328da0a82c8cba8dd7f9e537af2dd8ca60ebdf (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=7a609588a02281638e9a0cb57bed18966806349a
commit 7a609588a02281638e9a0cb57bed18966806349a
Author: Andreas Schwab <schwab@suse.de>
Date: Thu Aug 18 11:38:28 2016 +0200
arm: mark __startcontext as .cantunwind (bug 20435)
__startcontext marks the bottom of the call stack of the contexts created
by makecontext.
(cherry picked from commit 9e2ff6c9cc54c0b4402b8d49e4abe7000fde7617)
Also includes the NEWS update, cherry-picked from commits
056dd72af83f5459ce6d545a49dea6dba7d635dc and
4d047efdbc55b0d68947cde682e5363d16a66294.
diff --git a/ChangeLog b/ChangeLog
index 3d2063b..30da116 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-08-15 Andreas Schwab <schwab@suse.de>
+
+ [BZ #20435]
+ * ports/sysdeps/unix/sysv/linux/arm/setcontext.S (__startcontext):
+ Mark as .cantunwind.
+
2015-02-24 Eric Rannaud <e@nanocritical.com>
[BZ #17523]
diff --git a/NEWS b/NEWS
index 473e35a..a1bb834 100644
--- a/NEWS
+++ b/NEWS
@@ -96,6 +96,12 @@ Version 2.19.1
* The Sun RPC UDP client could exhaust all available stack space when
flooded with crafted ICMP and UDP messages. Reported by Aldy Hernandez'
alloca plugin for GCC. (CVE-2016-4429)
+
+* On ARM EABI (32-bit), generating a backtrace for execution contexts which
+ have been created with makecontext could fail to terminate due to a
+ missing .cantunwind annotation. This has been observed to lead to a hang
+ (denial of service) in some Go applications compiled with gccgo. Reported
+ by Andreas Schwab. (CVE-2016-6323)
Version 2.19
diff --git a/ports/sysdeps/unix/sysv/linux/arm/setcontext.S b/ports/sysdeps/unix/sysv/linux/arm/setcontext.S
index 7b9b511..7da16a9 100644
--- a/ports/sysdeps/unix/sysv/linux/arm/setcontext.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/setcontext.S
@@ -86,12 +86,19 @@ weak_alias(__setcontext, setcontext)
/* Called when a makecontext() context returns. Start the
context in R4 or fall through to exit(). */
+ /* Unwind descriptors are looked up based on PC - 2, so we have to
+ make sure to mark the instruction preceding the __startcontext
+ label as .cantunwind. */
+ .fnstart
+ .cantunwind
+ nop
ENTRY(__startcontext)
movs r0, r4
bne PLTJMP(__setcontext)
@ New context was 0 - exit
b PLTJMP(HIDDEN_JUMPTARGET(_exit))
+ .fnend
END(__startcontext)
#ifdef PIC
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 6 ++++++
NEWS | 6 ++++++
ports/sysdeps/unix/sysv/linux/arm/setcontext.S | 7 +++++++
3 files changed, 19 insertions(+), 0 deletions(-)
hooks/post-receive
--
GNU C Library master sources